chore(deps): update dependency eslint to v10#3573
Open
renovate[bot] wants to merge 1 commit intomasterfrom
Open
chore(deps): update dependency eslint to v10#3573renovate[bot] wants to merge 1 commit intomasterfrom
renovate[bot] wants to merge 1 commit intomasterfrom
Conversation
9eef386 to
2f2257c
Compare
4446b13 to
1f8f418
Compare
| "coveralls": "^3.1.1", | ||
| "cross-env": "^10.0.0", | ||
| "eslint": "^9.9.0", | ||
| "eslint": "^10.0.0", |
There was a problem hiding this comment.
Bug: The update to ESLint v10 is missing the required @eslint/js package in devDependencies, which is imported by the ESLint configuration, causing build and lint failures.
Severity: CRITICAL
Suggested Fix
Add the @eslint/js package to the devDependencies in package.json. The version should align with the eslint version, so "@eslint/js": "^10.0.0" is recommended.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: package.json#L159
Potential issue: The pull request upgrades `eslint` to version 10 but does not add the
`@eslint/js` package to `devDependencies`. ESLint v10 requires this package to be
installed separately. The project's configuration file, `eslint.config.mjs`, explicitly
imports `@eslint/js`. Consequently, when the CI runs `yarn run eslint` or a developer
runs `yarn start` or `yarn build`, the process will fail with a "module not found" error
because the required dependency is not installed. This will block linting, local
development, and production builds.
Did we get this right? 👍 / 👎 to inform future reviews.
62b555b to
f7e1792
Compare
f7e1792 to
0d3e067
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
^9.9.0→^10.0.0Release Notes
eslint/eslint (eslint)
v10.0.1Compare Source
Bug Fixes
c87d5bdfix: update eslint (#20531) (renovate[bot])d841001fix: updateminimatchto10.2.1to address security vulnerabilities (#20519) (루밀LuMir)04c2147fix: update error message for unused suppressions (#20496) (fnx)38b089cfix: update dependency @eslint/config-array to ^0.23.1 (#20484) (renovate[bot])Documentation
5b3dbcedocs: add AI acknowledgement section to templates (#20431) (루밀LuMir)6f23076docs: toggle nav in no-JS mode (#20476) (Tanuj Kanti)b69cfb3docs: Update README (GitHub Actions Bot)Chores
e5c281fchore: updates for v9.39.3 release (Jenkins)8c3832achore: update @typescript-eslint/parser to ^8.56.0 (#20514) (Milos Djermanovic)8330d23test: add tests for config-api (#20493) (Milos Djermanovic)37d6e91chore: remove eslint v10 prereleases from eslint-config-eslint deps (#20494) (Milos Djermanovic)da7cd0erefactor: cleanup error message templates (#20479) (Francesco Trotta)84fb885chore: package.json update for @eslint/js release (Jenkins)1f66734chore: addeslinttopeerDependenciesof@eslint/js(#20467) (Milos Djermanovic)v10.0.0Compare Source
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.