Skip to content

Hulk fix#3600

Open
Akshay-2007-1 wants to merge 5 commits intosource-academy:masterfrom
Akshay-2007-1:Hulk_fix
Open

Hulk fix#3600
Akshay-2007-1 wants to merge 5 commits intosource-academy:masterfrom
Akshay-2007-1:Hulk_fix

Conversation

@Akshay-2007-1
Copy link
Contributor

Description

This PR fixes the issue raised at #2970. The CSE Machine that wasn't included earlier in the green screen is included right now! The colors of the dead/faded text and stroke colors and the live versions have been switched due to the contrast of the background! Note that to enable Hulk mode, the hotkey is Alt + Shift + H while the cursor on the playground isn't enabled for typing.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Code quality improvements

How to test

Run the following code :

function scale_stream(c, stream) {
    return stream_map(x => c * x, stream);
}

const C = pair(1, () => scale_stream(2, C));

stream_ref(C, 2);

and at any valid step in between, you can see that after enabling Hulk mode through the above hotkey, the CSE Machine is a part of the green screen!

image

Checklist

  • I have tested this code
  • I have updated the documentation

Copy link
Member

@RichDom2185 RichDom2185 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason to switch the foreground color? The reason it exists is not for the visuals. It's because in lecture you just chroma key it the exact green out. So if you switch it, then the dark CSE machine foreground will be on top of the dark lecture Zoom background, making it invisible?

@Akshay-2007-1
Copy link
Contributor Author

Akshay-2007-1 commented Feb 23, 2026

Is there a reason to switch the foreground color? The reason it exists is not for the visuals. It's because in lecture you just chroma key it the exact green out. So if you switch it, then the dark CSE machine foreground will be on top of the dark lecture Zoom background, making it invisible?

Actually, I didn't know about this but what we realized is that in the Hulk mode, the faded dead frames from the recent Liveness algo was being highlighted MORE than the actual alive frames which is OPPOSITE to what we want i.e., live ones should be highlighted more. So, we asked Martin prof and he said this :

image

So how do we go about it?

@martin-henz
Copy link
Member

Oh, Richard is right. We need to view this in an environment where the green background is replaced by a dark background. I missed that in my discussion with the team.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants