refactor(stackable-telemetry)!: Rename Tracing to Telemetry#932
Open
refactor(stackable-telemetry)!: Rename Tracing to Telemetry#932
Conversation
NickLarsenNZ
requested changes
Dec 18, 2024
Member
NickLarsenNZ
left a comment
NickLarsenNZ
left a comment
There was a problem hiding this comment.
Please wait until I'm back. There's no rush on this yet, and I want to know how metrics fit in to this (from memory it is handled a little different, unless we massage the API a bit)
Member
Author
|
We'll hold off on this change until @NickLarsenNZ and I can take a look at how metrics will be handled and if they can be incorporated into the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR renames
TracingtoTelemetryto more appropriately reflect what the type does: constructing subscribers to process different telemetry signals (currently logs and traces).