[WIP] Add use of require.css and require.js#1
Open
RobLoach wants to merge 1 commit intostackphp:masterfrom
Open
[WIP] Add use of require.css and require.js#1RobLoach wants to merge 1 commit intostackphp:masterfrom
RobLoach wants to merge 1 commit intostackphp:masterfrom
Conversation
simensen
pushed a commit
that referenced
this pull request
Sep 24, 2015
loop back server address and composer order. are changed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is more of brainstorm than a pull request. This makes use of Component Installer's generated
require.jsandrequire.css, reducing the micro-management of dependencies, and the amount of HTTP requests.require.css: Concatenated stylesheet of all Component CSS filesrequire.js: Built RequireJS configuration for loading scripts, along with their dependencies@simensen and I had troubles getting RequireJS to pick up the correct base URL in Sculpin. We can get around that by telling Sculpin to register it directly in the template:
Was trying to use
hljs.initHighlightingOnLoad();here, and it wasn't quite working because I believe at the time the require callback is made, the page is already loaded and the event has already been triggered. I could be wrong though, but it is working with the following:Was wondering where this could improve, and was looking for both of your thoughts. I'm trying to get a better understanding of where Component Installer could be better, and how it could satisfy more use cases.
Thanks a lot! Stack looks great ❤️