Open
Conversation
jhnwu3
commented
Mar 10, 2026
| lock_path = Path(cache_dir) / "build.lock" | ||
| with FileLock(str(lock_path), timeout=7200): | ||
| # Re-check inside the lock — another process may have built it | ||
| # while we were waiting. |
Collaborator
Author
There was a problem hiding this comment.
Need help looking into file read checks like this. Mainly, for when the agent spins up multiple caching jobs at once, which leads to downstream issues like overwriting files, etc.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces new example scripts and documentation updates to support multimodal and hyperparameter-tuned drug recommendation models on the MIMIC-IV dataset, specifically using AdaCare and RETAIN model variants. It also improves the usability and clarity of existing example scripts.
Major additions and improvements:
1. New example scripts for drug recommendation:
drug_recommendation_mimic4_adacare.pydemonstrating how to use the AdaCare model for drug recommendation on MIMIC-IV, including data loading, task setup, training, evaluation, and prediction inspection.drug_recommendation_mimic4_adacare_optuna.py, providing an end-to-end example of hyperparameter tuning for AdaCare using Optuna, covering parameter search, training, and evaluation.drug_recommendation_mimic4_multimodal_retain.py, showcasing the use of the newMultimodalRETAINmodel for handling both sequential and non-sequential EHR features, with detailed steps and comparison to vanilla RETAIN.2. Documentation enhancements:
MultimodalAdaCareandMultimodalRETAINclasses, improving discoverability and API reference completeness. [1] [2]3. Usability and bug fixes in existing examples: