BridgeJS: Unify closure JS glue lift/lower #610
Merged
+251
−1,019
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Refactoring to unlock #598
Changes
We had been having closure-specific lift/lower logic for JS glue codegen:
closureLiftParameterclosureLowerReturnclosureLowerParameterclosureLiftReturnHowever, they are essentially the same as the regular lift/lower logic, so we should uniformly use them to reduce the cost of adding a new type support.