BridgeJS: Remove BasicFormat usage in ExportSwift #617
+900
−1,091
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxDesiatov
reviewed
Feb 11, 2026
| return statements | ||
| statements.append("_swift_js_push_i32(Int32(\(accessor).count))") | ||
| let parsed: CodeBlockItemListSyntax = "\(raw: statements.joined(separator: "\n"))" | ||
| return Array(parsed) |
Member
There was a problem hiding this comment.
Redundant copy here? Could this return some Sequence<CodeBlockItemSyntax> instead of you want it to avoid leaking CodeBlockItemListSyntax as a return type?
Member
Author
There was a problem hiding this comment.
This is just because the rest of StackCodegen expects [CodeBlockItemSyntax] now. This is unfortunate but it will be removed once we get rid of SwiftSyntax-based node construction at all.
MaxDesiatov
reviewed
Feb 11, 2026
| return statements | ||
| statements.append("_swift_js_push_i32(__bjs_isSome_\(varPrefix) ? 1 : 0)") | ||
| let parsed: CodeBlockItemListSyntax = "\(raw: statements.joined(separator: "\n"))" | ||
| return Array(parsed) |
kateinoigakukun
force-pushed
the
yt/remove-basicformat
branch
from
36aedb1 to
9162fa0
Compare
MaxDesiatov
approved these changes
Feb 11, 2026
Member
MaxDesiatov
left a comment
MaxDesiatov
left a comment
There was a problem hiding this comment.
Unfortunate that the diff is huge and there's unnecessary Array copying, but if it fixes the original issue, we can accept this as a temporary measure before subsequent optimizations are applied
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mitigate #512