fix(view): add props for width and height to x-icon#1969
Open
iamdadmin wants to merge 1 commit intotempestphp:3.xfrom
Open
fix(view): add props for width and height to x-icon#1969iamdadmin wants to merge 1 commit intotempestphp:3.xfrom
iamdadmin wants to merge 1 commit intotempestphp:3.xfrom
Conversation
Contributor
Author
|
Weird, I thought that checks were set for manual trigger, I know they are going to fail as it stands as the tests aren't finished, hence leaving it in draft. Sorry, had I known they'd run I wouldn't have raised it as a draft until I had clean tests! |
iamdadmin
changed the title
Contributor
Author
|
Ready for review, I'd suggest squashing this commit as prettier which wasn't supposed to run on markdown files, ran on markdown files and really messed up the formatting, so there's some regression commits that are over the top. |
brendt
requested changes
Feb 16, 2026
Member
brendt
left a comment
brendt
left a comment
There was a problem hiding this comment.
Some thoughts I'd like some input on
iamdadmin
force-pushed
the
3.x-x-icon-default-sizing
branch
from
944cddf to
744b7f9
Compare
Contributor
Author
|
Since there was a pile of regression commits due to some formatting errors, I rebased, and re-applied the changes to make this a cleaner commit. Ready for review again, thanks for the feedback! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1955
Add props for width and height to x-icon, and ability to disable it entirely so it can be set in style or class
Add prop for style
Update docs
Update tests