fix(database): prevent deeply nested has many map adding extra empty object#1995
Open
nunntom wants to merge 2 commits intotempestphp:3.xfrom
Open
fix(database): prevent deeply nested has many map adding extra empty object#1995nunntom wants to merge 2 commits intotempestphp:3.xfrom
nunntom wants to merge 2 commits intotempestphp:3.xfrom
Conversation
nunntom
commented
Feb 19, 2026
| } | ||
|
|
||
| if ($key) { | ||
| $data->set($key, $value); |
Author
There was a problem hiding this comment.
This $data-set seems like it adds the whole recursive path to this key, making the earlier $data->set with $originalKey unnecessary.
nunntom
commented
Feb 19, 2026
| $originalKey .= $relation->name . '.'; | ||
|
|
||
| if (! $data->hasKey(trim($originalKey, '.'))) { | ||
| $data->set(trim($originalKey, '.'), []); |
Author
There was a problem hiding this comment.
When about to add $key: "books.1.chapters.1.id", $originalKey is "books.chapters." so this adds an associative "chapters" => [] into the books array.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #1994
SelectModelMapperthat adds initial empty model. It doesn't seem necessary since the later$data->setadds the full nested path anyway. Please correct me if I'm wrong or if I broke anything. Tests are all still passing (including the failing one I added).