Left and right lifts along a displayed cat.#343
Open
patrick-nicodemus wants to merge 3 commits intothe1lab:mainfrom
Open
Left and right lifts along a displayed cat.#343patrick-nicodemus wants to merge 3 commits intothe1lab:mainfrom
patrick-nicodemus wants to merge 3 commits intothe1lab:mainfrom
Conversation
Member
TOTBWF
requested changes
Jan 16, 2024
Collaborator
|
Thanks so much for the PR! There are a couple of minor nits, but these are all nice additions :) I particularly like |
TOTBWF
approved these changes
Jan 28, 2024
ncfavier
requested changes
Jan 28, 2024
|
|
||
| The distinguished projection `πᶠ` has a canonical choice of lifting. | ||
| Later, we will prove that for any functor $F$ valued in | ||
| $\cE$, $\pi^f$ has a canonical choice of lifting; however, this later |
Member
There was a problem hiding this comment.
Suggested change
| $\cE$, $\pi^f$ has a canonical choice of lifting; however, this later | |
| $\cE$, $\pi^f \circ F$ has a canonical choice of lifting; however, this later |
Comment on lines
+154
to
+160
| module _ {o ℓ o' ℓ'} | ||
| {B : Precategory o ℓ} | ||
| (E : Displayed B o' ℓ') | ||
| where | ||
| open Cat.Reasoning B | ||
| open Displayed E | ||
| open Cat.Displayed.Reasoning E |
|
|
||
| πᶠ-lifting : Lifting E (πᶠ E) | ||
| πᶠ-lifting .Lifting.F₀' (_ , a) = a | ||
| πᶠ-lifting .Lifting.F₁' f = preserves f |
Member
There was a problem hiding this comment.
Suggested change
| πᶠ-lifting .Lifting.F₁' f = preserves f | |
| πᶠ-lifting .Lifting.F₁' f = f .preserves |
| πᶠ-lifting .Lifting.F-∘' f g = refl | ||
| ``` | ||
|
|
||
| Let $F: \cC\times \cD\to \cB$ be a functor and $\cE\liesover\cB$ a displayed category. Let $F' : \cC\times \cD\to \cE$ be a lift of $F$ along $F'$. We show that $F'(c-,)$ is a lift of $F(c,-)$ for any $c$, similarly $F'(-,d)$ is a lift of $F(-,d)$ for any $d$. |
Member
There was a problem hiding this comment.
Suggested change
| Let $F: \cC\times \cD\to \cB$ be a functor and $\cE\liesover\cB$ a displayed category. Let $F' : \cC\times \cD\to \cE$ be a lift of $F$ along $F'$. We show that $F'(c-,)$ is a lift of $F(c,-)$ for any $c$, similarly $F'(-,d)$ is a lift of $F(-,d)$ for any $d$. | |
| Let $F: \cC\times \cD\to \cB$ be a functor and $\cE\liesover\cB$ a displayed category. Let $F' : \cC\times \cD\to \cE$ be a lift of $F$. We show that $F'(c-,)$ is a lift of $F(c,-)$ for any $c$, similarly $F'(-,d)$ is a lift of $F(-,d)$ for any $d$. |
Also this should be reflowed to fit in the 72-character width limit.
Comment on lines
+172
to
+184
| module Bifunctor {o₁ ℓ₁ o₂ ℓ₂ o₃ ℓ₃ o₄ ℓ₄} | ||
| {B : Precategory o₁ ℓ₁} | ||
| (E : Displayed B o₂ ℓ₂) | ||
| (C : Precategory o₃ ℓ₃) | ||
| (D : Precategory o₄ ℓ₄) | ||
| (F : Functor (C ×ᶜ D) B) | ||
| (F' : Lifting E F) | ||
| where | ||
| private | ||
| module C = Precategory C | ||
| module D = Precategory D | ||
| module E = Displayed E | ||
| module F' = Lifting F' |
Comment on lines
+187
to
+189
| Left' d .Lifting.F₀' c = Lifting.F₀' F' (c , d) | ||
| Left' d .Lifting.F₁' f = Lifting.F₁' F' ( f , D.id ) | ||
| Left' d .Lifting.F-id' = Lifting.F-id' F' |
Member
There was a problem hiding this comment.
Suggested change
| Left' d .Lifting.F₀' c = Lifting.F₀' F' (c , d) | |
| Left' d .Lifting.F₁' f = Lifting.F₁' F' ( f , D.id ) | |
| Left' d .Lifting.F-id' = Lifting.F-id' F' | |
| Left' d .Lifting.F₀' c = F' .Lifting.F₀' (c , d) | |
| Left' d .Lifting.F₁' f = F' .Lifting.F₁' (f , D.id) | |
| Left' d .Lifting.F-id' = F' .Lifting.F-id' |
I guess this isn't in the style guide but please use postfix projections everywhere.
Comment on lines
+192
to
+197
| ((F'.F₁' (f , D.id) E.∘' | ||
| F'.F₁' (g , D.id)) | ||
| E.≡[]˘⟨ F'.F-∘' (f , D.id) (g , D.id) ⟩ | ||
| (ap (F' .Lifting.F₁') | ||
| (λ i → C._∘_ f g , D.idl (D.id) i) | ||
| E.∙[] refl)) |
Member
There was a problem hiding this comment.
The alignment is a bit awkward here, could you make this a proper reasoning chain ending with ∎?
Also it looks like the proofs of first∘first and second∘second could be simplified by omitting the outer sym and reversing the chain, which would also simplify these displayed proofs (but you don't have to do this).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Let$F: C\times D\to B$ be a functor and $p : E\to B$ a displayed category. Let $F' : C\times D\to E$ be a lift of $F$ along $F'$ . We show that $F'(c-,)$ is a lift of $F(c,-)$ for any $c$ , similarly $F'(-,d)$ is a lift of $F(-,d)$ for any $d$ .
The intended application of this theorem is to the theory of displayed bicategories.