[fix #430] pin gocov to v1.1.0 and remove duplicate install step in CDC CI#431
[fix #430] pin gocov to v1.1.0 and remove duplicate install step in CDC CI#431
Conversation
|
Hi @Copilot. Thanks for your PR. I'm waiting for a tikv member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@copilot please fix the ci failure include the "dco", please re-commit all your commit with signoff |
|
/test ? |
|
/test pull-integration-test |
|
/test pull-unit-test |
|
@wuhuizuo: Cannot trigger testing until a trusted user reviews the PR and leaves an DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/run-all-tests |
|
@wuhuizuo: Cannot trigger testing until a trusted user reviews the PR and leaves an DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
All new commits now include the |
Updated gocov to |
Signed-off-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: ti-chi-bot <71242396+ti-chi-bot@users.noreply.github.com>
|
@copilot looks like we can remove the install gocov tool action step to avoid duplicate |
The gocov tool is already installed by the Makefile's `gocov` target (pinned to v1.1.0), which is called as part of `unit_test_in_verify_ci`. The explicit workflow step was redundant. Signed-off-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: ti-chi-bot <71242396+ti-chi-bot@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #431 +/- ##
================================================
+ Coverage 62.0761% 62.1610% +0.0848%
================================================
Files 247 247
Lines 21174 21203 +29
================================================
+ Hits 13144 13180 +36
+ Misses 6820 6816 -4
+ Partials 1210 1207 -3
*This pull request uses carry forward flags. Click here to find out more. 🚀 New features to boost your workflow:
|
a17dbea to
760a7d5
Compare
Signed-off-by: wuhuizuo <wuhuizuo@126.com>
Signed-off-by: wuhuizuo <wuhuizuo@126.com>
760a7d5 to
7deeebc
Compare
Signed-off-by: wuhuizuo <wuhuizuo@126.com>
Signed-off-by: wuhuizuo <wuhuizuo@126.com>
Signed-off-by: wuhuizuo <wuhuizuo@126.com>
The `cdc-check` job is renamed to `verify` and now includes the `cdc-build-and-unit-test` steps. This simplifies the workflow by removing a separate job. Signed-off-by: wuhuizuo <wuhuizuo@126.com>
53d612a to
bd578b6
Compare
|
@Copilot: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
cdc-unit-testCI job was failing becausegocov@latestintroduced a breaking change. The explicit install step in the workflow was also a duplicate of what the Makefile already handles.What problem does this PR solve?
Problem Description:
cdc/tools/Makefileinstalledgocov@latest, causing non-reproducible builds and CI failures. The CI workflow also had a redundant explicit install step.What is changed and how does it work?
cdc/tools/Makefile: pingocovfrom@latest→@v1.1.0.github/workflows/ci-cdc.yml: remove the standalone "install gocov" step —make unit_test_in_verify_cialready invokes the Makefile'sgocovtarget which now installs the pinned versionCode changes
Check List for Tests
This PR has been tested by at least one of the following methods:
Side effects
Related changes
To reviewers
Please follow these principles to check this pull requests:
(The above text mainly refers to TiDB Development Guide. It's also highly recommended to read about Writing code review comments)
Original prompt
🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.