Open
Conversation
Author
|
This is the link to the diagram from yesterday's discussion: https://docs.google.com/drawings/d/1rl01dcu1RrFGlZg3IflaCt_Hq_c35PpwtjUR_BSOwng/edit |
| "uniqueItems": true, | ||
| "description": "The dimension names of the dataset, in order. e.g. ['time', 'radius']", | ||
| "items": { | ||
| "$ref": "/dimension", |
Member
There was a problem hiding this comment.
This one needs updating to use the full urn (I think).
Author
There was a problem hiding this comment.
"$ref": "https://raw.githubusercontent.com/ukaea/ukaea-metadata/1.0.0/ukaea-schema/experiment/mast/dimension.schema.json"
samueljackson92
commented
Aug 22, 2024
| "description": "Metadata to describe from diagnostic sources", | ||
| "type": "object", | ||
| "required": [ "name", "description", "source_type"], | ||
| "properties": { |
Author
There was a problem hiding this comment.
Names should be camelCase not snake_case.
samueljackson92
commented
Aug 22, 2024
| "type": "string" | ||
| } | ||
| } | ||
| } |
Author
There was a problem hiding this comment.
Follow this tutorial @samueljackson92 you noob https://tour.json-schema.org/content/01-Getting-Started/01-Your-First-Schema
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding a first pass of a meta data schema for MAST diagnostic data based on our meta database.
These attributes are mostly derived from the names used in UDA and used in the MAST-U user pages.
I suggest that this PR is a place where we can start to discuss this schema more broadly.