feat: discriminated union support in openapi.yml through flags#2
Open
nimarb wants to merge 1 commit intovercel-labs:mainfrom
Open
feat: discriminated union support in openapi.yml through flags#2nimarb wants to merge 1 commit intovercel-labs:mainfrom
nimarb wants to merge 1 commit intovercel-labs:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds discriminated union support and array/object body flags
generateBodyFlags()returned[]for schemas using oneOf/allOf/anyOf, making endpoints with discriminated unions unusable without --data. array and typeless object properties were silently skipped.This PR change flattens composition keywords into merged property sets before flag generation, and adds array/json flag types so fields like labels: array and config: object produce usable CLI flags.
Before, an endpoint with a oneOf request body showed no flags at all:
currently, we have to patch our
OpenAPI.ymlfile to flatten it before we use specli which is a bit annoying :). Hope the PR works / open to feedback etc !Thank you for providing this software!