Skip to content

feat(node-streams): add config flag, define-env, and env precedence test#90427

Open
timneutkens wants to merge 5 commits intographite-base/90427from
02-24-feat_node-streams_add_config_flag_define-env_and_env_precedence_test
Open

feat(node-streams): add config flag, define-env, and env precedence test#90427
timneutkens wants to merge 5 commits intographite-base/90427from
02-24-feat_node-streams_add_config_flag_define-env_and_env_precedence_test

Conversation

@timneutkens
Copy link
Member

@timneutkens timneutkens commented Feb 24, 2026 •
edited
Loading

What?

Split out these changes from #89859. Only adds more plumbing for future Node.js streams feature.

@timneutkens timneutkens mentioned this pull request Feb 24, 2026
Open
@timneutkens Graphite App
Copy link
Member Author

timneutkens commented Feb 24, 2026 •
edited
Loading

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@timneutkens timneutkens mentioned this pull request Feb 24, 2026
Closed
@timneutkens timneutkens marked this pull request as ready for review February 24, 2026 12:34
@vercel
Copy link
Contributor

vercel bot commented Feb 24, 2026 •
edited
Loading

Notifying the following users due to files changed in this PR based on this repo's notify modifiers:

@ijjk, @shuding, @huozhi:

packages/next/src/server/config.ts

This was referenced Feb 24, 2026
Closed
Draft
@timneutkens timneutkens force-pushed the 02-24-refactor_update_module.compiled.js_for_node_stream_support branch from 89eb403 to 7c95707 Compare February 24, 2026 13:16
@timneutkens timneutkens force-pushed the 02-24-feat_node-streams_add_config_flag_define-env_and_env_precedence_test branch 2 times, most recently from 54d7ab5 to e9d98ed Compare February 24, 2026 13:46
@nextjs-bot
Copy link
Collaborator

nextjs-bot commented Feb 24, 2026 •
edited
Loading

Stats from current PR

✅ No significant changes detected

📊 All Metrics
📖 Metrics Glossary

Dev Server Metrics:

  • Listen = TCP port starts accepting connections
  • First Request = HTTP server returns successful response
  • Cold = Fresh build (no cache)
  • Warm = With cached build artifacts

Build Metrics:

  • Fresh = Clean build (no .next directory)
  • Cached = With existing .next directory

Change Thresholds:

  • Time: Changes < 50ms AND < 10%, OR < 2% are insignificant
  • Size: Changes < 1KB AND < 1% are insignificant
  • All other changes are flagged to catch regressions

⚡ Dev Server

Metric Canary PR Change Trend
Cold (Listen) 456ms 455ms ✓ ▁▃▃▁█
Cold (Ready in log) 439ms 439ms ✓ ▁▂▃▂█
Cold (First Request) 1.257s 1.292s ✓ ▁▃▃▅█
Warm (Listen) 456ms 457ms ✓ ▁▂▃▁█
Warm (Ready in log) 447ms 448ms ✓ ▁▂▂▁█
Warm (First Request) 353ms 350ms ✓ ▁▂▂▁█
📦 Dev Server (Webpack) (Legacy)

📦 Dev Server (Webpack)

Metric Canary PR Change Trend
Cold (Listen) 456ms 455ms ✓ ███▁▁
Cold (Ready in log) 439ms 439ms ✓ ▅▆██▇
Cold (First Request) 1.882s 1.871s ✓ █▃▄▅▄
Warm (Listen) 455ms 456ms ✓ █▁▅▅▅
Warm (Ready in log) 438ms 438ms ✓ ▃▅▆▆▆
Warm (First Request) 1.891s 1.891s ✓ ▇▂▃▄▃

⚡ Production Builds

Metric Canary PR Change Trend
Fresh Build 3.993s 3.993s ✓ ▁▅▅▁█
Cached Build 4.048s 4.002s ✓ ▁▅▅▁█
📦 Production Builds (Webpack) (Legacy)

📦 Production Builds (Webpack)

Metric Canary PR Change Trend
Fresh Build 14.149s 14.130s ✓ █▁▁▂▂
Cached Build 14.296s 14.298s ✓ █▁▂▂▁
node_modules Size 474 MB 474 MB ✓ █████
📦 Bundle Sizes

Bundle Sizes

⚡ Turbopack

Client

Main Bundles: **399 kB** → **399 kB** ✅ -23 B

80 files with content-based hashes (individual files not comparable between builds)

Server

Middleware
Canary PR Change
middleware-b..fest.js gzip 769 B 763 B ✓
Total 769 B 763 B ✅ -6 B
Build Details
Build Manifests
Canary PR Change
_buildManifest.js gzip 451 B 450 B ✓
Total 451 B 450 B ✅ -1 B

📦 Webpack

Client

Main Bundles
Canary PR Change
5528-HASH.js gzip 5.48 kB N/A -
6280-HASH.js gzip 57.5 kB N/A -
6335.HASH.js gzip 169 B N/A -
912-HASH.js gzip 4.53 kB N/A -
e8aec2e4-HASH.js gzip 62.6 kB N/A -
framework-HASH.js gzip 59.7 kB 59.7 kB ✓
main-app-HASH.js gzip 255 B 254 B ✓
main-HASH.js gzip 39.1 kB 39.1 kB ✓
webpack-HASH.js gzip 1.68 kB 1.68 kB ✓
262-HASH.js gzip N/A 4.53 kB -
2889.HASH.js gzip N/A 169 B -
5602-HASH.js gzip N/A 5.49 kB -
6948ada0-HASH.js gzip N/A 62.6 kB -
9544-HASH.js gzip N/A 58.3 kB -
Total 231 kB 232 kB ⚠️ +755 B
Polyfills
Canary PR Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB ✓
Total 39.4 kB 39.4 kB ✓
Pages
Canary PR Change
_app-HASH.js gzip 194 B 194 B ✓
_error-HASH.js gzip 183 B 180 B 🟢 3 B (-2%)
css-HASH.js gzip 331 B 330 B ✓
dynamic-HASH.js gzip 1.81 kB 1.81 kB ✓
edge-ssr-HASH.js gzip 256 B 256 B ✓
head-HASH.js gzip 351 B 352 B ✓
hooks-HASH.js gzip 384 B 383 B ✓
image-HASH.js gzip 580 B 581 B ✓
index-HASH.js gzip 260 B 260 B ✓
link-HASH.js gzip 2.5 kB 2.5 kB ✓
routerDirect..HASH.js gzip 320 B 319 B ✓
script-HASH.js gzip 386 B 386 B ✓
withRouter-HASH.js gzip 315 B 315 B ✓
1afbb74e6ecf..834.css gzip 106 B 106 B ✓
Total 7.97 kB 7.97 kB ✅ -2 B

Server

Edge SSR
Canary PR Change
edge-ssr.js gzip 125 kB 125 kB ✓
page.js gzip 252 kB 253 kB ✓
Total 377 kB 378 kB ⚠️ +588 B
Middleware
Canary PR Change
middleware-b..fest.js gzip 615 B 611 B ✓
middleware-r..fest.js gzip 156 B 155 B ✓
middleware.js gzip 43.8 kB 44 kB ✓
edge-runtime..pack.js gzip 842 B 842 B ✓
Total 45.4 kB 45.6 kB ⚠️ +204 B
Build Details
Build Manifests
Canary PR Change
_buildManifest.js gzip 715 B 718 B ✓
Total 715 B 718 B ⚠️ +3 B
Build Cache
Canary PR Change
0.pack gzip 3.98 MB 3.99 MB 🔴 +14.5 kB (+0%)
index.pack gzip 102 kB 102 kB ✓
index.pack.old gzip 103 kB 101 kB 🟢 1.93 kB (-2%)
Total 4.18 MB 4.19 MB ⚠️ +12.3 kB

🔄 Shared (bundler-independent)

Runtimes
Canary PR Change
app-page-exp...dev.js gzip 318 kB 318 kB ✓
app-page-exp..prod.js gzip 168 kB 169 kB ✓
app-page-tur...dev.js gzip 318 kB 318 kB ✓
app-page-tur..prod.js gzip 168 kB 168 kB ✓
app-page-tur...dev.js gzip 314 kB 314 kB ✓
app-page-tur..prod.js gzip 166 kB 166 kB ✓
app-page.run...dev.js gzip 315 kB 315 kB ✓
app-page.run..prod.js gzip 167 kB 167 kB ✓
app-route-ex...dev.js gzip 70.7 kB 70.7 kB ✓
app-route-ex..prod.js gzip 49.1 kB 49.1 kB ✓
app-route-tu...dev.js gzip 70.7 kB 70.7 kB ✓
app-route-tu..prod.js gzip 49.2 kB 49.2 kB ✓
app-route-tu...dev.js gzip 70.3 kB 70.3 kB ✓
app-route-tu..prod.js gzip 48.9 kB 48.9 kB ✓
app-route.ru...dev.js gzip 70.2 kB 70.2 kB ✓
app-route.ru..prod.js gzip 48.9 kB 48.9 kB ✓
dist_client_...dev.js gzip 324 B 324 B ✓
dist_client_...dev.js gzip 326 B 326 B ✓
dist_client_...dev.js gzip 318 B 318 B ✓
dist_client_...dev.js gzip 317 B 317 B ✓
pages-api-tu...dev.js gzip 43.2 kB 43.2 kB ✓
pages-api-tu..prod.js gzip 32.9 kB 32.9 kB ✓
pages-api.ru...dev.js gzip 43.2 kB 43.2 kB ✓
pages-api.ru..prod.js gzip 32.8 kB 32.8 kB ✓
pages-turbo....dev.js gzip 52.5 kB 52.5 kB ✓
pages-turbo...prod.js gzip 38.5 kB 38.5 kB ✓
pages.runtim...dev.js gzip 52.5 kB 52.5 kB ✓
pages.runtim..prod.js gzip 38.4 kB 38.4 kB ✓
server.runti..prod.js gzip 62 kB 62.1 kB ✓
Total 2.81 MB 2.81 MB ⚠️ +240 B
📝 Changed Files (9 files)

Files with changes:

  • app-page-exp..ntime.dev.js
  • app-page-exp..time.prod.js
  • app-page-tur..ntime.dev.js
  • app-page-tur..time.prod.js
  • app-page-tur..ntime.dev.js
  • app-page-tur..time.prod.js
  • app-page.runtime.dev.js
  • app-page.runtime.prod.js
  • server.runtime.prod.js
View diffs
app-page-exp..ntime.dev.js 
failed to diff
app-page-exp..time.prod.js

Diff too large to display

app-page-tur..ntime.dev.js 
failed to diff
app-page-tur..time.prod.js

Diff too large to display

app-page-tur..ntime.dev.js 
failed to diff
app-page-tur..time.prod.js 
failed to diff
app-page.runtime.dev.js 
failed to diff
app-page.runtime.prod.js

Diff too large to display

server.runtime.prod.js

Diff too large to display

📎 Tarball URL 
next@https://vercel-packages.vercel.app/next/prs/90427/next

@timneutkens timneutkens changed the base branch from 02-24-refactor_update_module.compiled.js_for_node_stream_support to graphite-base/90427 February 24, 2026 15:05
@timneutkens timneutkens force-pushed the 02-24-feat_node-streams_add_config_flag_define-env_and_env_precedence_test branch from 87b3b57 to 84a63ed Compare February 24, 2026 15:05
@timneutkens timneutkens mentioned this pull request Feb 25, 2026
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

created-by: Turbopack team PRs by the Turbopack team. tests type: next

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@timneutkens @nextjs-bot