Skip to content

Refactor command detection list to use a single unified source#8

Open
insign wants to merge 1 commit intomainfrom
refactor/unify-command-starters-359382809472215330
Open

Refactor command detection list to use a single unified source#8
insign wants to merge 1 commit intomainfrom
refactor/unify-command-starters-359382809472215330

Conversation

@insign
Copy link
Contributor

@insign insign commented Mar 5, 2026

This PR unifies the command_starters array used for detecting shell commands. Previously, a duplicated, slightly shorter list was hardcoded in src/cli/mod.rs while a more complete list existed as COMMAND_STARTERS in src/providers/mod.rs. Making the constant public ensures consistency and reduces code duplication.


PR created automatically by Jules for task 359382809472215330 started by @insign

Exported `COMMAND_STARTERS` from `src/providers/mod.rs` and replaced the local hardcoded array in `src/cli/mod.rs` to ensure consistent command detection across the codebase.
@google-labs-jules
Copy link

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@chatgpt-codex-connector
Copy link

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant