Conversation
chkshsgr: This program is used to verify if the compilation environment is enough to run getgroups() and setgroups().
0x5c
added a commit
to 0x5c/runit
that referenced
this pull request
Mar 27, 2023
prot.c provides two functions: prot_gid and prot_uid.
prot_gid is fully unused, and depends on {chk,try}shsgr, both of which must be
run at build-time and require that the user has additional groups. They are not
needed by anything else and their removal gets rid of cross-compilation jank.
prot_uid is used (once) by chpst, but since it is a no-op wrapper around
setuid(), its use can be replaced by a normal call to setuid().
Solves the big questions from void-linux#11
0x5c
added a commit
to 0x5c/runit
that referenced
this pull request
Mar 27, 2023
The "systype" machanism is merely a system info gatherer, and the info it collects is (mostly) not used anywhere. The only seemingly important info is the kernel and kernel version (or the lack thereof), and has been moved to where it is used (print-ar.sh) This gets rid of two cross-incompatible buildtime programs. One tried to find if the build was happening on NeXT, but that's not an operating system that print-ar.sh cares about. The other tried to do cpuid on x86, which is useless to the build. This seems to implement what void-linux#11 started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed the chkshsgr and systype checks. This one is still a bit WIP. Technically,
chkshsgrchecks if the build system can adequately run thehasshsgrtest, so just removing it isn't the the best policy.How should we alter the build style? Should it be made to support only platforms that we do / reasonably modern platforms, eliminating the need for all the
choosechecks we are doing, or should it be made to still work with all the platforms it originally did?