Fix browser tool to not discard content when screenshot fails#156
Open
04cb wants to merge 1 commit intovxcontrol:masterfrom
Open
Fix browser tool to not discard content when screenshot fails#15604cb wants to merge 1 commit intovxcontrol:masterfrom
04cb wants to merge 1 commit intovxcontrol:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue #149. The browser tool was discarding successfully-fetched page content when screenshot capture failed. Screenshot is a non-critical side-effect used only for logging, so failures should be logged as warnings without affecting the primary content fetch operation.
Changes:
All three methods now return valid content with empty screenshot name when screenshot fails, rather than returning an error and discarding the content.