Skip to content

Conversation

@bjohansebas
Copy link
Member

Summary

Okay, this took me a bit of time to understand. This is something similar to what send does. After several attempts, it can probably be refactored even more, but this would be the main solution.

The send workflow is: if it detects a trailing slash at the end of pathname ("/") (line of code), then it goes into another code path, where it joins the original pathname and appends the index (line of code which is configurable, just like in this package). When they are joined, if such an index file exists, it continues with the normal workflow, otherwise, it throws an error, similar to what is handled here. The difference is that now, if there is a trailing slash, the index file (which is configurable) is also appended

What kind of change does this PR introduce?

Did you add tests for your changes?

Does this PR introduce a breaking change?

yes!

If relevant, what needs to be documented once your changes are merged or what have you already documented?

@codecov
Copy link

codecov bot commented Jan 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.70%. Comparing base (35dd70b) to head (ee8725d).

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #2255      +/-   ##
==========================================
+ Coverage   95.67%   95.70%   +0.02%     
==========================================
  Files          13       13              
  Lines         901      907       +6     
  Branches      263      267       +4     
==========================================
+ Hits          862      868       +6     
  Misses         39       39              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants