Fix image len bound check in update_ram.c#706
Merged
dgarske merged 2 commits intowolfSSL:masterfrom Mar 2, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a missing bounds check to RAM-boot image loading to reject oversized images and extends the unit test suite to cover invalid headers, oversize rejection, and a successful RAM-boot path. This aligns wolfBoot_ramboot() behavior with existing fixed-partition size constraints used elsewhere in the image handling code.
Changes:
- Add a partition-size-based upper bound check for the image payload length in
wolfBoot_ramboot(). - Add unit tests for RAM-boot: invalid magic, oversized length rejection, and success case.
- Register the new tests in the unit test suite runner.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/update_ram.c |
Rejects images whose header-advertised payload size exceeds WOLFBOOT_PARTITION_SIZE - IMAGE_HEADER_SIZE before reading into RAM. |
tools/unit-tests/unit-update-ram.c |
Adds and registers coverage for RAM-boot failure/success paths (invalid header, oversize, success). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
dgarske
approved these changes
Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes Fenrir/228