Fix include/lib path ordering so wolfSSL paths take precedence#372
Open
ColtonWilley wants to merge 1 commit intowolfSSL:masterfrom
Open
Fix include/lib path ordering so wolfSSL paths take precedence#372ColtonWilley wants to merge 1 commit intowolfSSL:masterfrom
ColtonWilley wants to merge 1 commit intowolfSSL:masterfrom
Conversation
When --with-openssl=<prefix> contains stale wolfSSL headers, the compiler picked them up because OpenSSL's -I path appeared before wolfSSL's in CFLAGS. Swap the wolfSSL and OpenSSL detection blocks so wolfSSL's -I/-L paths are added first and take precedence. Also move AC_CHECK_HEADERS for openssl/core.h after OpenSSL paths are set so it can actually find the header.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When --with-openssl= contains stale wolfSSL headers, the compiler picked them up because OpenSSL's -I path appeared before wolfSSL's in CFLAGS. Swap the wolfSSL and OpenSSL detection blocks so wolfSSL's -I/-L paths are added first and take precedence. Also move AC_CHECK_HEADERS for openssl/core.h after OpenSSL paths are set so it can actually find the header.
Fixes ZD 21214