Use heap allocation for CSR PEM conversion on small stack builds#462
Merged
dgarske merged 1 commit intowolfSSL:masterfrom Feb 24, 2026
Merged
Use heap allocation for CSR PEM conversion on small stack builds#462dgarske merged 1 commit intowolfSSL:masterfrom
dgarske merged 1 commit intowolfSSL:masterfrom
Conversation
…location for small stack builds
There was a problem hiding this comment.
Pull request overview
This PR optimizes memory usage in TPM2 CSR generation for resource-constrained environments by conditionally using heap allocation instead of stack allocation for temporary PEM conversion buffers.
Changes:
- Added conditional compilation logic to allocate PEM conversion buffers on the heap when
WOLFTPM_SMALL_STACKis defined - Introduced
derSzvariable to improve clarity when tracking DER size throughout the conversion process
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
dgarske
approved these changes
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request improves memory handling in the PEM conversion process within the TPM2 CSR generation code, particularly for environments with constrained stack space. The changes ensure that temporary buffers are dynamically allocated when needed, reducing stack usage and preventing potential buffer overflows.
Memory management improvements for PEM conversion:
CSR_MakeAndSignandCSR_MakeAndSign_Cbfunctions insrc/tpm2_wrap.c, added conditional logic to allocate the temporary buffer on the heap usingXMALLOCwhenWOLFTPM_SMALL_STACKis defined, and to free it withXFREEafter use. This helps support devices with limited stack space. [1] [2]derSzvariable, improving code clarity and correctness. [1] [2]