Open
Conversation
Contributor
ejohnstown
commented
Mar 6, 2026
- When disabling mlkem768nistp256-sha256, there's a crash when doing a mlkem768x25519-sha256 KEX. It tries to do a DH key exchange instead of x25519 with ML-KEM. Modified the check.
- Fixed a guard where the build was treating not having mlkem768nistp256-sha256 like a FIPS build disallowing using ML-KEM when generating sesssion keys. It shouldn't make that check.
- Added a test case to the KEM test.
1. When disabling mlkem768nistp256-sha256, there's a crash when doing a mlkem768x25519-sha256 KEX. It tries to do a DH key exchange instead of x25519 with ML-KEM. Modified the check. 2. Fixed a guard where the build was treating not having mlkem768nistp256-sha256 like a FIPS build disallowing using ML-KEM when generating sesssion keys. It shouldn't make that check. 3. Added a test case to the KEM test.
There was a problem hiding this comment.
Pull request overview
This PR fixes two bugs related to ML-KEM key exchange (KEX) handling in wolfSSH and adds a corresponding test case.
Changes:
- Fixed a crash when performing
mlkem768x25519-sha256KEX whilemlkem768nistp256-sha256is disabled, by replacing a complex negated condition with a directuseDhflag check. - Removed an incorrect guard in
GenerateKeythat was treating the absence ofWOLFSSH_NO_NISTP256_MLKEM768_SHA256like a FIPS build, preventing ML-KEM session key generation. - Added a test case for the
mlkem768nistp256-sha256KEX algorithm.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/internal.c | Fixes the flawed DH condition check and the incorrect GenerateKey preprocessor guard |
| tests/kex.c | Adds a test case for mlkem768nistp256-sha256 KEX |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
JacobBarthelmeh
approved these changes
Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.