Improved c++14/17 integration, follows more closely modern cmake#175
Open
emmenlau wants to merge 1 commit intoxtensor-stack:masterfrom
Open
Improved c++14/17 integration, follows more closely modern cmake#175emmenlau wants to merge 1 commit intoxtensor-stack:masterfrom
emmenlau wants to merge 1 commit intoxtensor-stack:masterfrom
Conversation
emmenlau
force-pushed
the
bda_cppstandard_update
branch
from
3e6c2d2 to
9175d7e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently xtensor-blas supports cmake prior to 3.8 by not using
target_compile_featuresto set the c++14/17 standard. This can be a problem when mixed with projects that do usetarget_compile_featuresto set the standard, because cmake will not match the two choices. Therefore with the current implementation, both flags may be effective at the same time, which can result in compiler options likewhere the later option wins.
If xtensor should continue to support cmake prior to 3.8, then I propose to use
target_compile_featureswhen a sufficiently recent cmake is found. Otherwise I'd recommend to set the minimum cmake to 3.8?