fix: return the correct error on io.CopyN failure#4652
Open
joonas wants to merge 1 commit intozarf-dev:mainfrom
Open
fix: return the correct error on io.CopyN failure#4652joonas wants to merge 1 commit intozarf-dev:mainfrom
joonas wants to merge 1 commit intozarf-dev:mainfrom
Conversation
Signed-off-by: Joonas Bergius <joonas@defenseunicorns.com>
✅ Deploy Preview for zarf-docs canceled.
|
Codecov Report❌ Patch coverage is
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The code was erroneously returning
errinstead ofcopyErr, which will be set tonilfrom theos.OpenFileabove.Instead, I believe the intent was to return
copyErrif it is an unexpected error (i.e. notio.EOF).Related Issue
Sorry, I didn't create an issue for this.
Checklist before merging