Skip to content

Fix recent cards service#4263

Open
tintinthong wants to merge 1 commit intomainfrom
fix-recent-cards-service
Open

Fix recent cards service#4263
tintinthong wants to merge 1 commit intomainfrom
fix-recent-cards-service

Conversation

@tintinthong
Copy link
Copy Markdown
Contributor

No description provided.

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2b0c7d3d5d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

if (isLocalId(newId)) {
let instance = this.store.peek(newId);
if (isCardInstance(instance)) {
if (isCardInstance(instance) && instance.id && !isLocalId(instance.id)) {
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Keep subscribing when local cards have no remote id

Do not gate addNewCard on instance.id here: when add() is called with a local stack ID for a newly created card, the instance commonly has id === undefined (only localId is set). Before this change, addNewCard() handled that case by subscribing to id changes and adding the remote ID once assigned; now the call is skipped entirely, so the card never gets into recent cards (and optional recent-files propagation never occurs) after first save.

Useful? React with 👍 / 👎.

@github-actions
Copy link
Copy Markdown

Preview deployments

@github-actions
Copy link
Copy Markdown

Host Test Results

    1 files  ±  0      1 suites  ±0   2h 0m 18s ⏱️ - 12m 15s
1 853 tests  - 204  1 839 ✅  - 203  13 💤  - 2  0 ❌ ±0  1 🔥 +1 
1 867 runs   - 205  1 852 ✅  - 205  13 💤  - 2  1 ❌ +1  1 🔥 +1 

For more details on these errors, see this check.

Results for commit 2b0c7d3. ± Comparison against base commit 9daf8a6.

This pull request removes 204 tests.
Chrome ‑ Acceptance | Spec preview > Commands that depend on Proxy endpoints: generate readme button populates readme field via proxy command
Chrome ‑ Acceptance | Spec preview: can render containedExamples for spec for field
Chrome ‑ Acceptance | Spec preview: clicking view instance button correctly navigates to spec file and displays content in editor
Chrome ‑ Acceptance | Spec preview: does not lose input field focus when editing spec
Chrome ‑ Acceptance | Spec preview: have ability to create new spec instances
Chrome ‑ Acceptance | Spec preview: it does not set the wrong spec for field playground
Chrome ‑ Acceptance | Spec preview: primitive fields do not have examples
Chrome ‑ Acceptance | Spec preview: renders contained examples in isolated spec view when user can write (via view instance)
Chrome ‑ Acceptance | Spec preview: renders contained examples in isolated spec view when user cannot write
Chrome ‑ Acceptance | Spec preview: renders linked examples in isolated spec view when user can write (via view instance)
…

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant