Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2b0c7d3d5d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (isLocalId(newId)) { | ||
| let instance = this.store.peek(newId); | ||
| if (isCardInstance(instance)) { | ||
| if (isCardInstance(instance) && instance.id && !isLocalId(instance.id)) { |
There was a problem hiding this comment.
Keep subscribing when local cards have no remote id
Do not gate addNewCard on instance.id here: when add() is called with a local stack ID for a newly created card, the instance commonly has id === undefined (only localId is set). Before this change, addNewCard() handled that case by subscribing to id changes and adding the remote ID once assigned; now the call is skipped entirely, so the card never gets into recent cards (and optional recent-files propagation never occurs) after first save.
Useful? React with 👍 / 👎.
Preview deployments |
Host Test Results 1 files ± 0 1 suites ±0 2h 0m 18s ⏱️ - 12m 15s For more details on these errors, see this check. Results for commit 2b0c7d3. ± Comparison against base commit 9daf8a6. This pull request removes 204 tests. |
No description provided.