Skip to content

Fix recent cards service #4263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tintinthong wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix recent cards service #4263

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/host/app/services/recent-cards-service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ export default class RecentCardsService extends Service {
add(newId: string) {
if (isLocalId(newId)) {
let instance = this.store.peek(newId);
if (isCardInstance(instance)) {
if (isCardInstance(instance) && instance.id && !isLocalId(instance.id)) {
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot Mar 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Keep subscribing when local cards have no remote id

Do not gate addNewCard on instance.id here: when add() is called with a local stack ID for a newly created card, the instance commonly has id === undefined (only localId is set). Before this change, addNewCard() handled that case by subscribing to id changes and adding the remote ID once assigned; now the call is skipped entirely, so the card never gets into recent cards (and optional recent-files propagation never occurs) after first save.

Useful? React with 👍 / 👎.

this.addNewCard(instance);
}
return;
Expand Down
Loading