Skip to content

Conversation

@eps1lon
Copy link
Collaborator

@eps1lon eps1lon commented Feb 10, 2026

Mostly to make it easier to reason locally about this code. Rename and delete relied implicitly on inspectElementRaw to only show state for Class Components but there was already a TODO to expand that which would've crashed rename and delete.

Flagged by Claude + Opus 4.6 (which didn't make the connection with inspectElementRaw and assumed this fixes a crash).

@meta-cla meta-cla bot added the CLA Signed label Feb 10, 2026
@github-actions github-actions bot added the React Core Team Opened by a member of the React Core Team label Feb 10, 2026
@eps1lon eps1lon marked this pull request as ready for review February 10, 2026 09:41
@djhdusjbd-eng
Copy link

djhdusjbd-eng commented Feb 10, 2026 via email

@eps1lon eps1lon requested a review from hoxyq February 10, 2026 11:27
Co-authored-by: Ruslan Lesiutin <28902667+hoxyq@users.noreply.github.com>
@eps1lon eps1lon requested a review from hoxyq February 10, 2026 14:47
@eps1lon eps1lon merged commit 70890e7 into facebook:main Feb 10, 2026
631 of 637 checks passed
@eps1lon eps1lon deleted the sebbie/02-10-consistent_handling_of_work_tags_for_rename_delete_and_overriding_state branch February 10, 2026 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed React Core Team Opened by a member of the React Core Team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants