Skip to content

Consistent handling of work tags for rename, delete, and overriding state #35740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eps1lon merged 2 commits into from
Feb 10, 2026
+17 −4
Merged

Consistent handling of work tags for rename, delete, and overriding state #35740

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c9e7491
Consistent handling of work tags for rename, delete, and overriding s…
eps1lon Feb 10, 2026
96c7609
Update packages/react-devtools-shared/src/backend/fiber/renderer.js
eps1lon Feb 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 17 additions & 4 deletions packages/react-devtools-shared/src/backend/fiber/renderer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6859,6 +6859,8 @@ export function attach(

// TODO Show custom UI for Cache like we do for Suspense
// For now, just hide state data entirely since it's not meant to be inspected.
// Make sure delete, rename, and override of state handles all tags for which
// we show state.
const showState =
tag === ClassComponent || tag === IncompleteClassComponent;

Expand Down Expand Up @@ -7815,8 +7817,13 @@ export function attach(
}
break;
case 'state':
deletePathInObject(instance.state, path);
instance.forceUpdate();
switch (fiber.tag) {
case ClassComponent:
case IncompleteClassComponent:
deletePathInObject(instance.state, path);
instance.forceUpdate();
break;
}
break;
}
}
Expand Down Expand Up @@ -7893,8 +7900,13 @@ export function attach(
}
break;
case 'state':
renamePathInObject(instance.state, oldPath, newPath);
instance.forceUpdate();
switch (fiber.tag) {
case ClassComponent:
case IncompleteClassComponent:
renamePathInObject(instance.state, oldPath, newPath);
instance.forceUpdate();
break;
}
break;
}
}
Expand Down Expand Up @@ -7964,6 +7976,7 @@ export function attach(
case 'state':
switch (fiber.tag) {
case ClassComponent:
case IncompleteClassComponent:
setInObject(instance.state, path, value);
instance.forceUpdate();
break;
Expand Down
Loading