-
Notifications
You must be signed in to change notification settings - Fork 123
refactor(psr3): align trace_id and span_id to snake_case #498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
refactor(psr3): align trace_id and span_id to snake_case #498
Conversation
|
Thanks for opening your first pull request! If you haven't yet signed our Contributor License Agreement (CLA), then please do so that we can accept your contribution. A link should appear shortly in this PR if you have not already signed one. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #498 +/- ##
============================================
- Coverage 83.46% 83.44% -0.02%
Complexity 2330 2330
============================================
Files 149 149
Lines 8791 8791
============================================
- Hits 7337 7336 -1
- Misses 1454 1455 +1 Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
|
Hi @ChrisLightfootWild, |
|
"Hello @ChrisLightfootWild! I see that the checks are failing, but the errors are coming from the Symfony instrumentation and Sampler modules, which are outside the scope of my PSR-3 refactoring. Since these appear to be existing upstream issues, could you advise on how to proceed so we can merge this? Thanks!" |
|
@drghdtjr you can ignore those failures. If your PR didn't break it, you don't need to fix it. |
|
Thanks for the reviews @brettmc and @ChrisLightfootWild! If there’s any feedback on the code, I’m happy to make updates. Otherwise, would it be okay to proceed with merging this PR? |
Description
This PR aligns the
traceIdandspanIdkeys totrace_idandspan_id(snake_case) in the PSR-3 instrumentation. This change ensures consistency with OpenTelemetry semantic conventions and aligns with other language SDKs as discussed in the issue.Changes
Psr3Instrumentation.phpto use snake_case for trace and span IDs.Psr3InstrumentationTest.phpto reflect these naming changes in integration tests.Related Issue
Fixes #1744
open-telemetry/opentelemetry-php#1744